test_legacy.py 14 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472
  1. # Copyright (c) Twisted Matrix Laboratories.
  2. # See LICENSE for details.
  3. """
  4. Test cases for L{twisted.logger._legacy}.
  5. """
  6. from time import time
  7. import logging as py_logging
  8. from zope.interface.verify import verifyObject, BrokenMethodImplementation
  9. from twisted.trial import unittest
  10. from twisted.python import context
  11. from twisted.python import log as legacyLog
  12. from twisted.python.failure import Failure
  13. from .._levels import LogLevel
  14. from .._observer import ILogObserver
  15. from .._format import formatEvent
  16. from .._legacy import LegacyLogObserverWrapper
  17. from .._legacy import publishToNewObserver
  18. class LegacyLogObserverWrapperTests(unittest.TestCase):
  19. """
  20. Tests for L{LegacyLogObserverWrapper}.
  21. """
  22. def test_interface(self):
  23. """
  24. L{LegacyLogObserverWrapper} is an L{ILogObserver}.
  25. """
  26. legacyObserver = lambda e: None
  27. observer = LegacyLogObserverWrapper(legacyObserver)
  28. try:
  29. verifyObject(ILogObserver, observer)
  30. except BrokenMethodImplementation as e:
  31. self.fail(e)
  32. def test_repr(self):
  33. """
  34. L{LegacyLogObserverWrapper} returns the expected string.
  35. """
  36. class LegacyObserver(object):
  37. def __repr__(self):
  38. return "<Legacy Observer>"
  39. def __call__(self):
  40. return
  41. observer = LegacyLogObserverWrapper(LegacyObserver())
  42. self.assertEqual(
  43. repr(observer),
  44. "LegacyLogObserverWrapper(<Legacy Observer>)"
  45. )
  46. def observe(self, event):
  47. """
  48. Send an event to a wrapped legacy observer and capture the event as
  49. seen by that observer.
  50. @param event: an event
  51. @type event: L{dict}
  52. @return: the event as observed by the legacy wrapper
  53. """
  54. events = []
  55. legacyObserver = lambda e: events.append(e)
  56. observer = LegacyLogObserverWrapper(legacyObserver)
  57. observer(event)
  58. self.assertEqual(len(events), 1)
  59. return events[0]
  60. def forwardAndVerify(self, event):
  61. """
  62. Send an event to a wrapped legacy observer and verify that its data is
  63. preserved.
  64. @param event: an event
  65. @type event: L{dict}
  66. @return: the event as observed by the legacy wrapper
  67. """
  68. # Make sure keys that are expected by the logging system are present
  69. event.setdefault("log_time", time())
  70. event.setdefault("log_system", "-")
  71. event.setdefault("log_level", LogLevel.info)
  72. # Send a copy: don't mutate me, bro
  73. observed = self.observe(dict(event))
  74. # Don't expect modifications
  75. for key, value in event.items():
  76. self.assertIn(key, observed)
  77. return observed
  78. def test_forward(self):
  79. """
  80. Basic forwarding: event keys as observed by a legacy observer are the
  81. same.
  82. """
  83. self.forwardAndVerify(dict(foo=1, bar=2))
  84. def test_time(self):
  85. """
  86. The new-style C{"log_time"} key is copied to the old-style C{"time"}
  87. key.
  88. """
  89. stamp = time()
  90. event = self.forwardAndVerify(dict(log_time=stamp))
  91. self.assertEqual(event["time"], stamp)
  92. def test_timeAlreadySet(self):
  93. """
  94. The new-style C{"log_time"} key does not step on a pre-existing
  95. old-style C{"time"} key.
  96. """
  97. stamp = time()
  98. event = self.forwardAndVerify(dict(log_time=stamp + 1, time=stamp))
  99. self.assertEqual(event["time"], stamp)
  100. def test_system(self):
  101. """
  102. The new-style C{"log_system"} key is copied to the old-style
  103. C{"system"} key.
  104. """
  105. event = self.forwardAndVerify(dict(log_system="foo"))
  106. self.assertEqual(event["system"], "foo")
  107. def test_systemAlreadySet(self):
  108. """
  109. The new-style C{"log_system"} key does not step on a pre-existing
  110. old-style C{"system"} key.
  111. """
  112. event = self.forwardAndVerify(dict(log_system="foo", system="bar"))
  113. self.assertEqual(event["system"], "bar")
  114. def test_noSystem(self):
  115. """
  116. If the new-style C{"log_system"} key is absent, the old-style
  117. C{"system"} key is set to C{"-"}.
  118. """
  119. # Don't use forwardAndVerify(), since that sets log_system.
  120. event = dict(log_time=time(), log_level=LogLevel.info)
  121. observed = self.observe(dict(event))
  122. self.assertEqual(observed["system"], "-")
  123. def test_levelNotChange(self):
  124. """
  125. If explicitly set, the C{isError} key will be preserved when forwarding
  126. from a new-style logging emitter to a legacy logging observer,
  127. regardless of log level.
  128. """
  129. self.forwardAndVerify(dict(log_level=LogLevel.info, isError=1))
  130. self.forwardAndVerify(dict(log_level=LogLevel.warn, isError=1))
  131. self.forwardAndVerify(dict(log_level=LogLevel.error, isError=0))
  132. self.forwardAndVerify(dict(log_level=LogLevel.critical, isError=0))
  133. def test_pythonLogLevelNotSet(self):
  134. """
  135. The new-style C{"log_level"} key is not translated to the old-style
  136. C{"logLevel"} key.
  137. Events are forwarded from the old module from to new module and are
  138. then seen by old-style observers.
  139. We don't want to add unexpected keys to old-style events.
  140. """
  141. event = self.forwardAndVerify(dict(log_level=LogLevel.info))
  142. self.assertNotIn("logLevel", event)
  143. def test_stringPythonLogLevel(self):
  144. """
  145. If a stdlib log level was provided as a string (eg. C{"WARNING"}) in
  146. the legacy "logLevel" key, it does not get converted to a number.
  147. The documentation suggested that numerical values should be used but
  148. this was not a requirement.
  149. """
  150. event = self.forwardAndVerify(dict(
  151. logLevel="WARNING", # py_logging.WARNING is 30
  152. ))
  153. self.assertEqual(event["logLevel"], "WARNING")
  154. def test_message(self):
  155. """
  156. The old-style C{"message"} key is added, even if no new-style
  157. C{"log_format"} is given, as it is required, but may be empty.
  158. """
  159. event = self.forwardAndVerify(dict())
  160. self.assertEqual(event["message"], ()) # "message" is a tuple
  161. def test_messageAlreadySet(self):
  162. """
  163. The old-style C{"message"} key is not modified if it already exists.
  164. """
  165. event = self.forwardAndVerify(dict(message=("foo", "bar")))
  166. self.assertEqual(event["message"], ("foo", "bar"))
  167. def test_format(self):
  168. """
  169. Formatting is translated such that text is rendered correctly, even
  170. though old-style logging doesn't use PEP 3101 formatting.
  171. """
  172. event = self.forwardAndVerify(
  173. dict(log_format="Hello, {who}!", who="world")
  174. )
  175. self.assertEqual(
  176. legacyLog.textFromEventDict(event),
  177. "Hello, world!"
  178. )
  179. def test_formatMessage(self):
  180. """
  181. Using the message key, which is special in old-style, works for
  182. new-style formatting.
  183. """
  184. event = self.forwardAndVerify(
  185. dict(log_format="Hello, {message}!", message="world")
  186. )
  187. self.assertEqual(
  188. legacyLog.textFromEventDict(event),
  189. "Hello, world!"
  190. )
  191. def test_formatAlreadySet(self):
  192. """
  193. Formatting is not altered if the old-style C{"format"} key already
  194. exists.
  195. """
  196. event = self.forwardAndVerify(
  197. dict(log_format="Hello!", format="Howdy!")
  198. )
  199. self.assertEqual(legacyLog.textFromEventDict(event), "Howdy!")
  200. def eventWithFailure(self, **values):
  201. """
  202. Create a new-style event with a captured failure.
  203. @param values: Additional values to include in the event.
  204. @type values: L{dict}
  205. @return: the new event
  206. @rtype: L{dict}
  207. """
  208. failure = Failure(RuntimeError("nyargh!"))
  209. return self.forwardAndVerify(dict(
  210. log_failure=failure,
  211. log_format="oopsie...",
  212. **values
  213. ))
  214. def test_failure(self):
  215. """
  216. Captured failures in the new style set the old-style C{"failure"},
  217. C{"isError"}, and C{"why"} keys.
  218. """
  219. event = self.eventWithFailure()
  220. self.assertIs(event["failure"], event["log_failure"])
  221. self.assertTrue(event["isError"])
  222. self.assertEqual(event["why"], "oopsie...")
  223. def test_failureAlreadySet(self):
  224. """
  225. Captured failures in the new style do not step on a pre-existing
  226. old-style C{"failure"} key.
  227. """
  228. failure = Failure(RuntimeError("Weak salsa!"))
  229. event = self.eventWithFailure(failure=failure)
  230. self.assertIs(event["failure"], failure)
  231. def test_isErrorAlreadySet(self):
  232. """
  233. Captured failures in the new style do not step on a pre-existing
  234. old-style C{"isError"} key.
  235. """
  236. event = self.eventWithFailure(isError=0)
  237. self.assertEqual(event["isError"], 0)
  238. def test_whyAlreadySet(self):
  239. """
  240. Captured failures in the new style do not step on a pre-existing
  241. old-style C{"failure"} key.
  242. """
  243. event = self.eventWithFailure(why="blah")
  244. self.assertEqual(event["why"], "blah")
  245. class PublishToNewObserverTests(unittest.TestCase):
  246. """
  247. Tests for L{publishToNewObserver}.
  248. """
  249. def setUp(self):
  250. self.events = []
  251. self.observer = self.events.append
  252. def legacyEvent(self, *message, **values):
  253. """
  254. Return a basic old-style event as would be created by L{legacyLog.msg}.
  255. @param message: a message event value in the legacy event format
  256. @type message: L{tuple} of L{bytes}
  257. @param values: additional event values in the legacy event format
  258. @type event: L{dict}
  259. @return: a legacy event
  260. """
  261. event = (context.get(legacyLog.ILogContext) or {}).copy()
  262. event.update(values)
  263. event["message"] = message
  264. event["time"] = time()
  265. if "isError" not in event:
  266. event["isError"] = 0
  267. return event
  268. def test_observed(self):
  269. """
  270. The observer is called exactly once.
  271. """
  272. publishToNewObserver(
  273. self.observer, self.legacyEvent(), legacyLog.textFromEventDict
  274. )
  275. self.assertEqual(len(self.events), 1)
  276. def test_time(self):
  277. """
  278. The old-style C{"time"} key is copied to the new-style C{"log_time"}
  279. key.
  280. """
  281. publishToNewObserver(
  282. self.observer, self.legacyEvent(), legacyLog.textFromEventDict
  283. )
  284. self.assertEqual(
  285. self.events[0]["log_time"], self.events[0]["time"]
  286. )
  287. def test_message(self):
  288. """
  289. A published old-style event should format as text in the same way as
  290. the given C{textFromEventDict} callable would format it.
  291. """
  292. def textFromEventDict(event):
  293. return "".join(reversed(" ".join(event["message"])))
  294. event = self.legacyEvent("Hello,", "world!")
  295. text = textFromEventDict(event)
  296. publishToNewObserver(self.observer, event, textFromEventDict)
  297. self.assertEqual(formatEvent(self.events[0]), text)
  298. def test_defaultLogLevel(self):
  299. """
  300. Published event should have log level of L{LogLevel.info}.
  301. """
  302. publishToNewObserver(
  303. self.observer, self.legacyEvent(), legacyLog.textFromEventDict
  304. )
  305. self.assertEqual(self.events[0]["log_level"], LogLevel.info)
  306. def test_isError(self):
  307. """
  308. If C{"isError"} is set to C{1} (true) on the legacy event, the
  309. C{"log_level"} key should get set to L{LogLevel.critical}.
  310. """
  311. publishToNewObserver(
  312. self.observer,
  313. self.legacyEvent(isError=1),
  314. legacyLog.textFromEventDict
  315. )
  316. self.assertEqual(self.events[0]["log_level"], LogLevel.critical)
  317. def test_stdlibLogLevel(self):
  318. """
  319. If the old-style C{"logLevel"} key is set to a standard library logging
  320. level, using a predefined (L{int}) constant, the new-style
  321. C{"log_level"} key should get set to the corresponding log level.
  322. """
  323. publishToNewObserver(
  324. self.observer,
  325. self.legacyEvent(logLevel=py_logging.WARNING),
  326. legacyLog.textFromEventDict
  327. )
  328. self.assertEqual(self.events[0]["log_level"], LogLevel.warn)
  329. def test_stdlibLogLevelWithString(self):
  330. """
  331. If the old-style C{"logLevel"} key is set to a standard library logging
  332. level, using a string value, the new-style C{"log_level"} key should
  333. get set to the corresponding log level.
  334. """
  335. publishToNewObserver(
  336. self.observer,
  337. self.legacyEvent(logLevel="WARNING"),
  338. legacyLog.textFromEventDict
  339. )
  340. self.assertEqual(self.events[0]["log_level"], LogLevel.warn)
  341. def test_stdlibLogLevelWithGarbage(self):
  342. """
  343. If the old-style C{"logLevel"} key is set to a standard library logging
  344. level, using an unknown value, the new-style C{"log_level"} key should
  345. not get set.
  346. """
  347. publishToNewObserver(
  348. self.observer,
  349. self.legacyEvent(logLevel="Foo!!!!!"),
  350. legacyLog.textFromEventDict
  351. )
  352. self.assertNotIn("log_level", self.events[0])
  353. def test_defaultNamespace(self):
  354. """
  355. Published event should have a namespace of C{"log_legacy"} to indicate
  356. that it was forwarded from legacy logging.
  357. """
  358. publishToNewObserver(
  359. self.observer, self.legacyEvent(), legacyLog.textFromEventDict
  360. )
  361. self.assertEqual(self.events[0]["log_namespace"], "log_legacy")
  362. def test_system(self):
  363. """
  364. The old-style C{"system"} key is copied to the new-style
  365. C{"log_system"} key.
  366. """
  367. publishToNewObserver(
  368. self.observer, self.legacyEvent(), legacyLog.textFromEventDict
  369. )
  370. self.assertEqual(
  371. self.events[0]["log_system"], self.events[0]["system"]
  372. )